[PATCH] D118222: [RISCV] Split f64 undef into two integer undefs
Fraser Cormack via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 26 01:58:09 PST 2022
frasercrmck added a comment.
This could do with some tests to show the effect on codegen.
================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:8362
+ // If the source is undef, we split it into two integer undefs. No need to
+ // remove SrcDef since pass `processimpdefs` will do the favor.
+ MachineInstr* SrcDef = RegInfo.getVRegDef(SrcReg);
----------------
"since the ProcessImplicitDefs pass will do it for us". I don't think referring to the `DEBUG_TYPE` is as helpful.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118222/new/
https://reviews.llvm.org/D118222
More information about the llvm-commits
mailing list