[PATCH] D118123: [AMDGPU][MC][GFX9] Enabled TBA/TMA access via setreg/getreg

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 25 05:34:06 PST 2022


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp:1035-1036
+    return isGFX9(STI) || isGFX10(STI);
+  case ID_POPS_PACKER:
+    return isGFX10(STI);
   default:
----------------
foad wrote:
> Did you mean to include this in this patch?
Oh, I see, adding the check for POPS_PACKER is NFC because the getLastSymbolicHwreg would exclude it for GFX9 and below anyway. I guess it is OK to leave it here for consistency if you prefer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118123/new/

https://reviews.llvm.org/D118123



More information about the llvm-commits mailing list