[PATCH] D116821: [DebugInfo][InstrRef] Move instr-ref controlling flag out of TargetOptions

[Eric Christopher via llvm-commits]

It's mostly that we try very hard to not have #if 0 blocks in code please :)

The XFAIL * means that it also won't show up when you try to turn it on or
if something breaks. An option will let you explicitly keep that code
tested.

Thanks!

-eric

On Mon, Jan 24, 2022 at 12:43 PM Jeremy Morse via Phabricator <
reviews at reviews.llvm.org> wrote:

> jmorse added a comment.
>
> In D116821#3266623 <https://reviews.llvm.org/D116821#3266623>, @xbolva00
> wrote:
>
> > You could default this option to just false, instead of ifdefing it out,
> so anybody could enable it explicitly.
>
> Possibly I'm misunderstanding but: below the #if 0'd block, there's a test
> of the cl::opt that allows that:
>
>   return ValueTrackingVariableLocations == cl::boolOrDefault::BOU_TRUE;
>
> So that anyone can specify `-mllvm
> -experimental-debug-variable-locations=true` to get the instr-ref
> behaviour. The command-line-flag defaults to "unset", causing
> llvm::debuginfoShouldUseDebugInstrRef to return false on "main" right now.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D116821/new/
>
> https://reviews.llvm.org/D116821
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220124/979d5aad/attachment.html>