[PATCH] D116821: [DebugInfo][InstrRef] Move instr-ref controlling flag out of TargetOptions

Mon Jan 24 09:43:30 PST 2022

jmorse added a comment.

In D116821#3266623 <https://reviews.llvm.org/D116821#3266623>, @xbolva00 wrote:

> You could default this option to just false, instead of ifdefing it out, so anybody could enable it explicitly.

Possibly I'm misunderstanding but: below the #if 0'd block, there's a test of the cl::opt that allows that:

  return ValueTrackingVariableLocations == cl::boolOrDefault::BOU_TRUE;

So that anyone can specify `-mllvm -experimental-debug-variable-locations=true` to get the instr-ref behaviour. The command-line-flag defaults to "unset", causing llvm::debuginfoShouldUseDebugInstrRef to return false on "main" right now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116821/new/

https://reviews.llvm.org/D116821