[PATCH] D117947: [RISCV] Don't allow i64 vector div by constant to use mulh with Zve64x

Yueh-Ting Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 24 09:23:29 PST 2022


eopXD added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:615
 
+      // Vectors implement MULHS/MULHU.
+      // nxvXi64 MULHS/MULHU requires the V extension instead of Zve64*.
----------------
frasercrmck wrote:
> Do we need to move this comment down? It still applies at its previous location, doesn't it?
Yes you are correct. Change reverted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117947/new/

https://reviews.llvm.org/D117947



More information about the llvm-commits mailing list