[PATCH] D118008: [demangler] write-protect non-canonical source

Nathan Sidwell via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 24 03:55:43 PST 2022


urnathan marked an inline comment as done.
urnathan added a comment.

In D118008#3265198 <https://reviews.llvm.org/D118008#3265198>, @serge-sans-paille wrote:

> In D118008#3265195 <https://reviews.llvm.org/D118008#3265195>, @serge-sans-paille wrote:
>
>> May I suggest an alternate approach: it could be cmake's job to do the copying. That way the LLVM headers would never live in git, and there would be only one source for each of them (?)
>
> But that would mean a cross-project rule, which is probably not a good thing. Forget about it.

Either that or remove the duplication entirely.  Either requires more effort than I have the time for :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118008/new/

https://reviews.llvm.org/D118008



More information about the llvm-commits mailing list