[PATCH] D118008: [demangler] write-protect non-canonical source

[Nathan Sidwell via Phabricator via llvm-commits]

urnathan marked an inline comment as done.
urnathan added inline comments.


================
Comment at: libcxxabi/src/demangle/cp-to-llvm.sh:28-33
+	rm -f $LLVM_DEMANGLE_DIR/$I
+	cat - $I >$LLVM_DEMANGLE_DIR/$I <<EOF
+// Do not edit! -*- read-only -*-
+// See README.txt for instructions
+EOF
+	chmod -w $LLVM_DEMANGLE_DIR/$I
----------------
ChuanqiXu wrote:
> Is the indentation proper?
yes, that's a HERE document, so needs the indentation you want the output to have.  Upsets the script's indentation as you noticed


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118008/new/

https://reviews.llvm.org/D118008