[PATCH] D117944: [AARCH64][NEON] Allow to sink operands for aarch64_neon_pmull.

Mon Jan 24 00:58:52 PST 2022

fhahn added inline comments.

================
Comment at: llvm/test/CodeGen/AArch64/neon-vmull-high-p8.ll:8
+
+define <8 x i16> @test_pmull2_sink(<16 x i8> %a, <16 x i8> %b, <8 x i16> %c, i1 %t) {
+entry:
----------------
it would also be good to add a few negative tests, where sinking won't happen, e.g. because there are users in other blocks. Also cases where the other or both shuffles need sinking.

================
Comment at: llvm/test/CodeGen/AArch64/neon-vmull-high-p8.ll:14
+;
+  %0 = shufflevector <16 x i8> %a, <16 x i8> undef, <8 x i32> <i32 8, i32 9, i32 10, i32 11, i32 12, i32 13, i32 14, i32 15>
+  br i1 %t, label %if.then, label %cleanup
----------------
it think nowadays this should use poison here

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117944/new/

https://reviews.llvm.org/D117944