[PATCH] D117944: [AARCH64][NEON] Allow to sink operands for aarch64_neon_pmull.

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:12109
       }
       LLVM_FALLTHROUGH;
 
----------------
This falls through to trying to treat the instruction like an indexed pmul, which isn't an instruction available in AArch64. This could do with a test case and possibly being guarded against.


================
Comment at: llvm/test/CodeGen/AArch64/neon-vmull-high-p8.ll:1
+; RUN: llc < %s -verify-machineinstrs -mtriple=aarch64-linux-gnu -mattr=+neon | FileCheck %s
+
----------------
Can you run update_llc_test_checks on the file. It's useful in cases like this to show all the output


================
Comment at: llvm/test/CodeGen/AArch64/neon-vmull-high-p8.ll:26
+declare <8 x i16> @llvm.aarch64.neon.pmull.v8i16(<8 x i8>, <8 x i8>) #0
+attributes #0 = { nofree noinline nounwind }
----------------
I think you can likely remove this too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117944/new/

https://reviews.llvm.org/D117944