[PATCH] D110016: Check for invalid projects passed in LLVM_ENABLE_PROJECTS

[Joao Paulo Labegalini de Carvalho via Phabricator via llvm-commits]

jaopaulolc added inline comments.


================
Comment at: llvm/CMakeLists.txt:71
 # List of all known projects in the mono repo
 set(LLVM_KNOWN_PROJECTS "${LLVM_ALL_PROJECTS};${LLVM_EXTRA_PROJECTS}")
 set(LLVM_ENABLE_PROJECTS "" CACHE STRING
----------------
mehdi_amini wrote:
> jaopaulolc wrote:
> > Shouldn't  `LLVM_EXTERNAL_PROJECTS` be appended to `LLVM_KNOWN_PROJECTS` ?
> > 
> > Otherwise it would fail when a external project is configure with `-DLLVM_EXTERNAL_PROJECTS=foo-project -DLLVM_ENABLE_PROJECTS=foo`.
> > 
> > If so, the loop enabling the projects should just loop on `LLVM_KNOWN_PROJECTS`.
> From what I read line 129, you don't use `LLVM_ENABLE_PROJECTS` for external projects.
You are right, external projects should not be passed in `LLVM_ENABLE_PROJECTS`. Thanks for pointing that out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110016/new/

https://reviews.llvm.org/D110016