[PATCH] D116743: [PowerPC] Add assembly comments for instructions that use the vector registers.

Fri Jan 21 14:20:04 PST 2022

amyk accepted this revision as: amyk.
amyk added a comment.
This revision is now accepted and ready to land.

In D116743#3250956 <https://reviews.llvm.org/D116743#3250956>, @stefanp wrote:

> In D116743#3227465 <https://reviews.llvm.org/D116743#3227465>, @amyk wrote:
>
>> nit: The description has `regsiter` a number of times, please update it to `register`
>>
>> This a ver useful patch. Thanks Stefan! I have a question (might be silly but...), if verbose asm is enabled by default, does it require an update to more than the two test cases that you've updated in this patch? 
>> (I guess what I am getting at here is if verbose asm is enabled by default, I would have expected a whole bunch of other tests to also require updating, but I may be misunderstanding here.)
>
> For some reason I always seem to typo the word `register`. Not sure why... Anyway, thank you for finding them.
>
> Not a silly question at all!
> Initially I thought that I didn't need to update the tests because I wan't changing code and the CHECK/CHECK-NEXT lines don't really care that there are comments that come after the instructions. This is true in most cases but there are tests that already have a comment after the instruction line (for example `# 8-byte Folded Spill`) and in those cases by adding a second comment I'm adding a new line and the CHECK-NEXT lines don't work anymore. Anyway, I'm going to update those tests now.

Thanks for addressing the comment, Stefan!
I think overall, it LGTM.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116743/new/

https://reviews.llvm.org/D116743