[PATCH] D117694: [UpdateTestChecks] Add --filter and --filter-out options

David Greene via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 21 13:46:23 PST 2022


greened added inline comments.


================
Comment at: llvm/utils/UpdateTestChecks/common.py:101
+    """Filters are applied to each output line according to the order given. The
+    first matching filter terminates filter processing for that current line.""")
+
----------------
jdoerfert wrote:
> I only browsed the above code, looks good enough to me.
Yeah it's kind of unfortunate this has to be this complicated just to support deep copy.  Python 3.7 regexp objects support deep copy but we don't (yet?) require python 3.7.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117694/new/

https://reviews.llvm.org/D117694



More information about the llvm-commits mailing list