[PATCH] D117694: [UpdateTestChecks] Add --filter and --filter-out options

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

I like this. No real concern, maybe someone else want's to take a look, otherwise I can accept this.



================
Comment at: llvm/utils/UpdateTestChecks/common.py:44
+  """Augment a Regex object with a flag indicating whether a match should be
+    added (!is_filter_out) or rmoved (is_filter_out) from the generated checks.
+
----------------



================
Comment at: llvm/utils/UpdateTestChecks/common.py:101
+    """Filters are applied to each output line according to the order given. The
+    first matching filter terminates filter processing for that current line.""")
+
----------------
I only browsed the above code, looks good enough to me.


================
Comment at: llvm/utils/UpdateTestChecks/common.py:1045
+          autogenerated_note_args += new_arg
+    else:
+      autogenerated_note_args += action.option_strings[0] + ' '
----------------
pattern seemed to have been to use continue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117694/new/

https://reviews.llvm.org/D117694