[PATCH] D117781: [flang] Update tco tool pipline and add translation to LLVM IR

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 21 00:51:45 PST 2022


clementval added a comment.

In D117781#3260316 <https://reviews.llvm.org/D117781#3260316>, @mehdi_amini wrote:

> In D117781#3258703 <https://reviews.llvm.org/D117781#3258703>, @clementval wrote:
>
>> `fir-opt` doesn't have any defined pipeline and is similar to `mlir-opt`.
>
> Sure, but that's trivial to register pipelines and expose them on the command line. I think it is even **desirable** to do so (for example `opt` in LLVM exposes `-O2` on the command line).
>
>> We use it to test FIR to FIR passes.
>
> I think you're providing the definition for `fir-opt` here?

Yes it's `fir-opt`.

>> Once we have a proper flang driver that have similar capabilities than clang we might change the test to make use of it and maybe retire `tco`.
>
> LGTM, **assuming this tool is temporary and will get removed**. But I'd like to understand why the pipeline can't be all registered in `fir-opt`?

I guess we can merge the two tools at some point. `tco` was there before `fir-opt` so nobody took the time to merge the functionality of one into the other yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117781/new/

https://reviews.llvm.org/D117781



More information about the llvm-commits mailing list