[PATCH] D117781: [flang] Update tco tool pipline and add translation to LLVM IR

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini accepted this revision.
mehdi_amini added a comment.

In D117781#3258703 <https://reviews.llvm.org/D117781#3258703>, @clementval wrote:

> `fir-opt` doesn't have any defined pipeline and is similar to `mlir-opt`.

Sure, but that's trivial to register pipelines and expose them on the command line. I think it is even **desirable** to do so (for example `opt` in LLVM exposes `-O2` on the command line).

> We use it to test FIR to FIR passes.

I think you're providing the definition for `fir-opt` here?

> `tco` is meant to test the second half of the pipeline from FIR to LLVMIR. It has the same defined pipeline that the final Flang binary will have.

Right, but again I don't understand why you don't expose this by registering a pipeline in `fir-opt`?

> Once we have a proper flang driver that have similar capabilities than clang we might change the test to make use of it and maybe retire `tco`.

LGTM, assuming this tool is temporary and will get removed. But I'd like to understand why the pipeline can't be all registered in `fir-opt`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117781/new/

https://reviews.llvm.org/D117781