[PATCH] D117852: [CMake][WinMsvc] Replace MSVC_BASE/WINSDK_BASE with LLVM_WINSYSROOT

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 20 21:16:29 PST 2022


ychen created this revision.
ychen added reviewers: thakis, smeenai, mstorsjo.
Herald added a subscriber: mgorny.
ychen requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

- Using LLVM_WINSYSROOT would pick up DIA SDK path automatically, otherwise llvm-pdbutil has no DIA support.
- Add MSVC_VER to specify VC tools version.
- Make MSVC_VER/WINSDK_VER optional. If not specified, use the highest version number like the driver does.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117852

Files:
  llvm/cmake/platforms/WinMsvc.cmake

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117852.401855.patch
Type: text/x-patch
Size: 6625 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220121/72577d12/attachment.bin>


More information about the llvm-commits mailing list