[PATCH] D117741: [RISCV] Set CostPerUse to 1 iff RVC is enabled
Wang Pengcheng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 20 19:01:01 PST 2022
pcwang-thead added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.td:181
let RegAltNameIndices = [ABIRegAltName] in {
+ let CostPerUse = [0, 1] in {
def F0_H : RISCVReg16<0, "f0", ["ft0"]>, DwarfRegNum<[32]>;
----------------
craig.topper wrote:
> We discussed this at the RISC-V sync up this morning. I don't believe this should be part of this patch. Relaxing the restriction on non-RVC as you did in your original revision is non-controversial. Applying a new restriction on floating point with RVC may require performance measurements to be done.
Thanks. I will revert this patch to the original version and create another one for floating point registers after running SPEC FP (if it's profitable).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117741/new/
https://reviews.llvm.org/D117741
More information about the llvm-commits
mailing list