[PATCH] D117753: [AArch64] Support for memset tagged intrinsic

[Son Tuan Vu via Phabricator via llvm-commits]

tyb0807 marked 3 inline comments as done.
tyb0807 added inline comments.


================
Comment at: clang/lib/Headers/arm_acle.h:734
+/* Memory Operations Intrinsics */
+#if __ARM_FEATURE_MOPS && __ARM_FEATURE_MEMORY_TAGGING
+#define __arm_mops_memset_tag(tagged_address, value, size)                     \
----------------
SjoerdMeijer wrote:
> Why does this also need MTE? I think the ACLE specifies this intrinsic to be available when __ARM_FEATURE_MOPS is defined?
Yes you are right, thanks for spotting this.


================
Comment at: clang/lib/Headers/arm_acle.h:736
+#define __arm_mops_memset_tag(tagged_address, value, size)                     \
+  __builtin_arm_mops_memset_tag(tagged_address, value, size)
+#endif
----------------
dmgreen wrote:
> dmgreen wrote:
> > The arguments are better named __value and __size, etc. That way they only use reserved names and uses won't run into trouble if they `#define value 42` before the include.
> Oh, I mean `__value` and `__size`, etc :)
Yes, thanks for the review


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117753/new/

https://reviews.llvm.org/D117753