[PATCH] D117753: [AArch64] Support for memset tagged intrinsic

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 20 09:30:58 PST 2022


dmgreen added inline comments.


================
Comment at: clang/lib/Headers/arm_acle.h:736
+#define __arm_mops_memset_tag(tagged_address, value, size)                     \
+  __builtin_arm_mops_memset_tag(tagged_address, value, size)
+#endif
----------------
dmgreen wrote:
> The arguments are better named __value and __size, etc. That way they only use reserved names and uses won't run into trouble if they `#define value 42` before the include.
Oh, I mean `__value` and `__size`, etc :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117753/new/

https://reviews.llvm.org/D117753



More information about the llvm-commits mailing list