[PATCH] D117763: [AArch64][GlobalISel] CodeGen for Armv8.8/9.3 MOPS

[Dave Green via Phabricator via llvm-commits]

dmgreen added reviewers: paquette, aemerson.
dmgreen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64O0PreLegalizerCombiner.cpp:90
   case TargetOpcode::G_MEMCPY_INLINE:
+    if (ST.hasMOPS())
+      return false;
----------------
Should these still be returning false, or are fixed length copies better left for the inline code?  The quality of the code matter less at O0, but we are likely better off being conservative for the time being, like we are for ISel.


================
Comment at: llvm/unittests/Target/AArch64/InstSizes.cpp:165
+      TM.get(), II.get(), "",
+      "  renamable $x0, dead renamable $x1 = MOPSMemorySetTaggingPseudo killed renamable $x0, killed renamable $x1, killed renamable $x2, implicit-def dead $nzcv\n",
+      [](AArch64InstrInfo &II, MachineFunction &MF) {
----------------
Nice test. Can you format it to limit the length of the line?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117763/new/

https://reviews.llvm.org/D117763