[PATCH] D117614: [lld][ELF] Add support for ADRP+ADD optimization for AArch64

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/aarch64-adrp-add.s:29
+## The option --no-relax is specified, no relaxations should be applied.
+# RUN: llvm-objdump --no-show-raw-insn -d %t/a | FileCheck %s --check-prefix=OUT-OF-ADR-RANGE
+
----------------
The CHECK prefixes may use IN-RANGE and OUT-OF_RANGE. The test filename has implied the `ADR` name.


================
Comment at: lld/test/ELF/aarch64-adrp-add.s:49
+.rodata
+.hidden x
+x:
----------------
Without .globl x is a STB_LOCAL symbol


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117614/new/

https://reviews.llvm.org/D117614