[PATCH] D117614: [lld][ELF] Add support for ADRP+ADD optimization for AArch64

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 19 19:39:12 PST 2022


MaskRay added a comment.

Looks good



================
Comment at: lld/ELF/Arch/AArch64.cpp:613
+    return false;
+  // Check if the addends of the both relocations are zero.
+  if (adrpRel.addend != 0 || addRel.addend != 0)
----------------
This comment and the above just describe what the code does and can be omitted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117614/new/

https://reviews.llvm.org/D117614



More information about the llvm-commits mailing list