[PATCH] D117244: [llvm-dis] Add an option `print-thinlto-index-only` in llvm-dis to print index in LLVM assembly.

Mingming Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 19 14:24:09 PST 2022


luna marked an inline comment as done.
luna added inline comments.


================
Comment at: llvm/tools/llvm-dis/llvm-dis.cpp:79
+    "dump-thinlto-index-only",
+    cl::desc("Only read thinlto index and dump the index as a bitcode file."),
+    cl::init(false), cl::Hidden, cl::cat(DisCategory));
----------------
tejohnson wrote:
> tejohnson wrote:
> > "dump the index as a bitcode file" Do you mean dump/print the LLVM assembly? Suggest replacing "dump" with "print" in the option also.
> I would remove "as a bitcode file" since we aren't printing as bitcode (bitcode is the encoded input format),  or use my initial suggestion to replace this with "LLVM assembly".
thanks for pointing this out! Update to LLVM assembly now. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117244/new/

https://reviews.llvm.org/D117244



More information about the llvm-commits mailing list