[PATCH] D117244: [llvm-dis] Add an option `print-thinlto-index-only` in llvm-dis to print index in LLVM assembly.

[Mingming Liu via Phabricator via llvm-commits]

luna added inline comments.


================
Comment at: llvm/test/Bitcode/thinlto-index-disassembled-by-llvm-dis.ll:15
+; RUN: llvm-dis --print-thinlto-index-only %t.thinlink.bc -o - | FileCheck %s --check-prefix=DIS
+; DIS: ^0 = module: (path: "{{.*}}thinlto-index-disassembled-by-llvm-dis.ll.tmp.thinlink.bc", hash:
+; DIS: ^1 = gv: (name: "aplusb", summaries: (function: (module: ^0, flags: (linkage: external, visibility: default, notEligibleToImport: 0, live: 0, dsoLocal: 0, canAutoHide: 0), insts: 2))) ; guid = 
----------------
tejohnson wrote:
> If you change the suffix part to a wildcard then I believe the same checking lines could be shared by both llvm-dis invocations (e.g. remove FULL below and use DIS). Or just stop matching after thinlto-index-disassembled-by-llvm-dis.ll.tmp instead of using a wildcard.
Done by stop matching after thinlto-index-disassembled-by-llvm-dis.ll.tmp

(Was initially thinking of keeping the suffix explicit but there is no ambiguity in the context anyway, so sharing is reasonable to me).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117244/new/

https://reviews.llvm.org/D117244