[lld] 84944b6 - [ELF] Simplify ObjFile<ELFT>::initializeSections. NFC

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 18 22:45:08 PST 2022


Author: Fangrui Song
Date: 2022-01-18T22:45:04-08:00
New Revision: 84944b63f36eb8c93e7cd887c30748ab6f59b314

URL: https://github.com/llvm/llvm-project/commit/84944b63f36eb8c93e7cd887c30748ab6f59b314
DIFF: https://github.com/llvm/llvm-project/commit/84944b63f36eb8c93e7cd887c30748ab6f59b314.diff

LOG: [ELF] Simplify ObjFile<ELFT>::initializeSections. NFC

Added: 
    

Modified: 
    lld/ELF/InputFiles.cpp

Removed: 
    


################################################################################
diff  --git a/lld/ELF/InputFiles.cpp b/lld/ELF/InputFiles.cpp
index a65b82f73d72b..bad9cc169cd1f 100644
--- a/lld/ELF/InputFiles.cpp
+++ b/lld/ELF/InputFiles.cpp
@@ -552,7 +552,7 @@ void ObjFile<ELFT>::initializeSections(bool ignoreComdats) {
 
   std::vector<ArrayRef<Elf_Word>> selectedGroups;
 
-  for (size_t i = 0, e = objSections.size(); i < e; ++i) {
+  for (size_t i = 0; i != size; ++i) {
     if (this->sections[i] == &InputSection::discarded)
       continue;
     const Elf_Shdr &sec = objSections[i];
@@ -638,7 +638,7 @@ void ObjFile<ELFT>::initializeSections(bool ignoreComdats) {
   //    such cases, the relocation section would attempt to reference a target
   //    section that has not yet been created. For simplicity, delay creation of
   //    relocation sections until now.
-  for (size_t i = 0, e = objSections.size(); i < e; ++i) {
+  for (size_t i = 0; i != size; ++i) {
     if (this->sections[i] == &InputSection::discarded)
       continue;
     const Elf_Shdr &sec = objSections[i];
@@ -652,7 +652,7 @@ void ObjFile<ELFT>::initializeSections(bool ignoreComdats) {
       continue;
 
     InputSectionBase *linkSec = nullptr;
-    if (sec.sh_link < this->sections.size())
+    if (sec.sh_link < size)
       linkSec = this->sections[sec.sh_link];
     if (!linkSec)
       fatal(toString(this) + ": invalid sh_link index: " + Twine(sec.sh_link));


        


More information about the llvm-commits mailing list