[PATCH] D117555: Revert "[ELF] Simplify elf::link exit. NFC"
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 18 03:47:14 PST 2022
fhahn created this revision.
Herald added subscribers: arichardson, emaste.
Herald added a reviewer: MaskRay.
fhahn requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Attempt track down cause for failing libomp tests.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D117555
Files:
lld/ELF/Driver.cpp
Index: lld/ELF/Driver.cpp
===================================================================
--- lld/ELF/Driver.cpp
+++ lld/ELF/Driver.cpp
@@ -129,12 +129,13 @@
// Exit immediately if we don't need to return to the caller.
// This saves time because the overhead of calling destructors
// for all globally-allocated objects is not negligible.
- int hasError = errorCount() ? 1 : 0;
if (canExitEarly)
- exitLld(hasError);
- else
+ exitLld(errorCount() ? 1 : 0);
+
+ bool ret = errorCount() == 0;
+ if (!canExitEarly)
errorHandler().reset();
- return !hasError;
+ return ret;
}
// Parses a linker -m option.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117555.400797.patch
Type: text/x-patch
Size: 640 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220118/3600ed16/attachment.bin>
More information about the llvm-commits
mailing list