[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

Wang Pengcheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 17 22:04:44 PST 2022


pcwang-thead added inline comments.


================
Comment at: llvm/lib/Support/TargetParser.cpp:339
+    if (ISAInfo.hasExtension("d"))
+      return "ilp32d";
     return "ilp32";
----------------
khchen wrote:
> why do we need to change the order?
IMO, when `e` is combined with `d`, `e` should have higher priority so that the default ABI will be `ilp32e` and then this error will be reported.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70401/new/

https://reviews.llvm.org/D70401



More information about the llvm-commits mailing list