[PATCH] D117497: [X86] Add some missing dependency-breaking zero idiom patterns to scheduler models

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/X86SchedBroadwell.td:1762
+    PSUBBrr, PSUBWrr, PSUBDrr, PSUBQrr,
+    PCMPGTBrr, PCMPGTDrr, PCMPGTQrr, PCMPGTWrr
+  ], ZeroIdiomPredicate>,
----------------
I didn't find this information on AoM. 


================
Comment at: llvm/test/tools/llvm-mca/X86/Znver1/zero-idioms.s:205
 # CHECK:      Register File statistics:
-# CHECK-NEXT: Total number of mappings created:    115
-# CHECK-NEXT: Max number of mappings used:         58
+# CHECK-NEXT: Total number of mappings created:    0
+# CHECK-NEXT: Max number of mappings used:         0
----------------
I know nothing about znver, but is 0 too aggressive?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117497/new/

https://reviews.llvm.org/D117497