[PATCH] D116479: [VPlan] Introduce and use BranchOnCount VPInstruction.

Bardia Mahjour via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 17 11:09:11 PST 2022


bmahjour added a comment.

In D116479#3246783 <https://reviews.llvm.org/D116479#3246783>, @fhahn wrote:

>> This commit somehow causes the "unroll.disable" metadata to be dropped from the vector epilogue loops. For example:
>
> Thanks for the heads-up. Looks like unfortunately the relevant check lines to guard against the regression have been removed earlier. It should be fixed by 070d1034da87 <https://reviews.llvm.org/rG070d1034da87c94d86d1a61245ecf068141fdf14>. I also tried to restore the original check lines removed by 278aa65cc495 <https://reviews.llvm.org/rG278aa65cc495b2f548018eb2fd96351d36b4591f>

Thanks for the fix and the reviving of the MD checks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116479/new/

https://reviews.llvm.org/D116479



More information about the llvm-commits mailing list