[PATCH] D117184: Fix failing assertion in SimplifyCFG.cpp as icmp gep fold to constant expression [NFC]

[Markus Lavin via Phabricator via llvm-commits]

markus added a comment.

In D117184#3247873 <https://reviews.llvm.org/D117184#3247873>, @nikic wrote:

>> For some reason, the pipeline does not get reduced further (cc @markus) even though we can run the first part (the cgscc pipeline) and then feed it into the second part (the function pipeline).
>
> Just looked into this a bit. Apparently the pipeline reduction looks into nested pass managers and will split up the cgscc pass manager, doing something like `cgscc(inline)` and `cgscc(the-rest),function(simplifycfg)`. This no longer reproduces the issue, and the reduction is aborted early.
>
> I think that either the early abort should be dropped so we later still try the `cgscc(inline,the-rest)` and `function(simplifycfg)` split, or pass manager splitting should be an entirely separate reduction step.

Right, I think what would make most sense would be to do multiple reduction steps where the tree depth where splitting is performed is increased for each reduction step.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117184/new/

https://reviews.llvm.org/D117184