[PATCH] D117184: Fix failing assertion in SimplifyCFG.cpp as icmp gep fold to constant expression [NFC]

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 17 02:31:29 PST 2022


nikic added a comment.

> For some reason, the pipeline does not get reduced further (cc @markus) even though we can run the first part (the cgscc pipeline) and then feed it into the second part (the function pipeline).

Just looked into this a bit. Apparently the pipeline reduction looks into nested pass managers and will split up the cgscc pass manager, doing something like `cgscc(inline)` and `cgscc(the-rest),function(simplifycfg)`. This no longer reproduces the issue, and the reduction is aborted early.

I think that either the early abort should be dropped so we later still try the `cgscc(inline,the-rest)` and `function(simplifycfg)` split, or pass manager splitting should be an entirely separate reduction step.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117184/new/

https://reviews.llvm.org/D117184



More information about the llvm-commits mailing list