[PATCH] D98136: [RISCV][RFC] Initially support the K-extension instructions on the LLVM MC layer

[Yueh-Ting Chen via Phabricator via llvm-commits]

eopXD added inline comments.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:73
+    {"zkt", RISCVExtensionVersion{1, 0}},
+    {"zk", RISCVExtensionVersion{1, 0}},
+
----------------
Regarding `zkn`, `zks`, `zk`, D112359 added extension implication as a separate function. I think you may need to rebase and do some modifications.


================
Comment at: llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp:430
     Insn = support::endian::read32le(Bytes.data());
+
     LLVM_DEBUG(dbgs() << "Trying RISCV32 table :\n");
----------------
craig.topper wrote:
> This looks unrelated to the rest of the patch.
Cleanup?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98136/new/

https://reviews.llvm.org/D98136