[PATCH] D117885: [OpaquePtrs] Deprecate PointerType::getElementType()

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 22 00:31:34 PST 2022


nikic added a comment.

In D117885#3262673 <https://reviews.llvm.org/D117885#3262673>, @dexonsmith wrote:

> Generally makes sense to me; staging you propose sounds right too.
>
> Wondering though, why "deprecated" instead of simple delete? Either one is liable to need a temporary revert in downstreams... I figure, either they'll care about warnings (maybe use `-Werror`) and'll need to revert, or they won't care and this'll go by without being fixed. But I'm not sure / don't feel strongly / etc.

I'd like to get this landed before the LLVM 14 branching, and I think it would be nice if the method is only deprecated in the release, so people don't have to scramble getting this resolved as part of the upgrade.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117885/new/

https://reviews.llvm.org/D117885



More information about the llvm-commits mailing list