[PATCH] D117885: [OpaquePtrs] Deprecate PointerType::getElementType()

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D117885#3262673 <https://reviews.llvm.org/D117885#3262673>, @dexonsmith wrote:

> Generally makes sense to me; staging you propose sounds right too.
>
> Wondering though, why "deprecated" instead of simple delete? Either one is liable to need a temporary revert in downstreams... I figure, either they'll care about warnings (maybe use `-Werror`) and'll need to revert, or they won't care and this'll go by without being fixed. But I'm not sure / don't feel strongly / etc.

Bit easier to disable the deprecation warning than revert the patch locally, perhaps. I think a deprecation's not a bad idea - and at least removing the function in a patch separately from the patch that removes all uses of it should make it easier for downstream folks.

(maybe even split this patch in two - one to add the new function, and another to deprecate the old one)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117885/new/

https://reviews.llvm.org/D117885