[PATCH] D117363: LLDB Windows x64 buildbot set lit -j8

[Omair Javaid via llvm-commits]

On Sat, 15 Jan 2022, 4:30 am Stella Stamenova via Phabricator, <
reviews at reviews.llvm.org> wrote:

> stella.stamenova added a comment.
>
> In D117363#3245124 <https://reviews.llvm.org/D117363#3245124>,
> @gkistanova wrote:
>
> >> I think they should be set in just one place to make the code more
> readable.
> >
> > I was about to suggest the same.
> >
> > It might be simpler and more straight forward to revert D116972 <
> https://reviews.llvm.org/D116972> and just explicitly specify the needed
> `LLVM_LIT_ARGS` in the `extra_cmake_args`.
> > If you would like to set `-v` and `-j` by default, that could be done by
> something like this:
> >
> >   defult_lit_args = '-v'
> >   if if jobs:
> >       defult_lit_args += " -j{jobs}".format(jobs=jobs)
> >   CmakeCommand.applyDefaultOptions(cmake_options, [
> >           ('-DLLVM_LIT_ARGS=', defult_lit_args),
> >           ])
>
> What about adding a separate parameter for the jobs for the tests? That
> way a different level of parallelism could be specified for build and test?
> That's the route I would have gone.
>
This sounds like a good idea. I have to make a couple of changes for Arm
Windows bot. Let me give this a bit more thought before I make a final
decision on this.

>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D117363/new/
>
> https://reviews.llvm.org/D117363
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220115/19c8313a/attachment.html>