[PATCH] D117363: LLDB Windows x64 buildbot set lit -j8

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova added a comment.

In D117363#3245124 <https://reviews.llvm.org/D117363#3245124>, @gkistanova wrote:

>> I think they should be set in just one place to make the code more readable.
>
> I was about to suggest the same.
>
> It might be simpler and more straight forward to revert D116972 <https://reviews.llvm.org/D116972> and just explicitly specify the needed `LLVM_LIT_ARGS` in the `extra_cmake_args`.
> If you would like to set `-v` and `-j` by default, that could be done by something like this:
>
>   defult_lit_args = '-v'
>   if if jobs:
>       defult_lit_args += " -j{jobs}".format(jobs=jobs)
>   CmakeCommand.applyDefaultOptions(cmake_options, [
>           ('-DLLVM_LIT_ARGS=', defult_lit_args),
>           ])

What about adding a separate parameter for the jobs for the tests? That way a different level of parallelism could be specified for build and test? That's the route I would have gone.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117363/new/

https://reviews.llvm.org/D117363