[PATCH] D117354: [lld-macho] Allow order files and call graph sorting to be used together

Leonard Grey via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 14 13:01:31 PST 2022


lgrey created this revision.
lgrey added a reviewer: thakis.
lgrey added a project: lld-macho.
Herald added a subscriber: mgorny.
Herald added a reviewer: lld-macho.
lgrey requested review of this revision.
Herald added a project: LLVM.

If both an order file and a call graph profile are present, the edges of the call graph which use symbols present in the order file are not used. All of the symbols in the order file will appear at the beginning of the section just as they do currently. In other words, the highest priority derived from the call graph will be below the lowest priority derived from the order file.

Practically, this change renames CallGraphSort.{h,cpp} to SectionPriorities.{h,cpp}, and most order file and call graph profile related code is moved into the new file to reduce duplication.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117354

Files:
  lld/MachO/CMakeLists.txt
  lld/MachO/CallGraphSort.cpp
  lld/MachO/CallGraphSort.h
  lld/MachO/Driver.cpp
  lld/MachO/SectionPriorities.cpp
  lld/MachO/SectionPriorities.h
  lld/MachO/Writer.cpp
  lld/test/MachO/cgprofile-orderfile.s
  llvm/utils/gn/secondary/lld/MachO/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117354.400114.patch
Type: text/x-patch
Size: 19290 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220114/659d5049/attachment.bin>


More information about the llvm-commits mailing list