[PATCH] D117016: [flang][examples] Add missing CMake dependencies
Andrzej Warzynski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 14 08:37:26 PST 2022
awarzynski added a comment.
In D117016#3243872 <https://reviews.llvm.org/D117016#3243872>, @clementval wrote:
>> I agree. We'd probably have to remove these *.inc files from all header files. I can't think of any other way.
>
> Why would you remove them?
So that various CMake targets don't depend on `acc_gen` or `omp_gen`. To me it's rather counter-intuitive that everything that includes `parse-tree.h` depends on `acc_gen` and `omp_gen`. But perhaps that's by design?
Anyway, @clementval , are you OK with this change?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117016/new/
https://reviews.llvm.org/D117016
More information about the llvm-commits
mailing list