[PATCH] D117016: [flang][examples] Add missing CMake dependencies

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 14 08:23:25 PST 2022


clementval added a comment.

In D117016#3243835 <https://reviews.llvm.org/D117016#3243835>, @awarzynski wrote:

> In D117016#3243314 <https://reviews.llvm.org/D117016#3243314>, @kiranchandramohan wrote:
>
>> Ideally, we should avoid depending on these targets directly.
>
> I agree. We'd probably have to remove these *.inc files from all header files. I can't think of any other way.

Why would you remove them? They are necessary. MLIR works on the same principle without any issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117016/new/

https://reviews.llvm.org/D117016



More information about the llvm-commits mailing list