[PATCH] D117265: [MemoryBuiltins] [NFC] Rename isAllocationFn

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 14 08:00:05 PST 2022


reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

I would consider this a regression in clarity.  isAllocationFn is *any* allocation function we know about.  isAllocLike is the weird one.  If you want to rename something, aim for that one.

Though, I'm hoping to just kill that off entirely in the nearish future.  We've only got a handful of places left, it's just those places are getting harder/slower to fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117265/new/

https://reviews.llvm.org/D117265



More information about the llvm-commits mailing list