[PATCH] D117250: [lld-macho] Mention string literal deduplication as a difference from ld64

Thu Jan 13 16:31:40 PST 2022

keith added a comment.

In D117250#3242166 <https://reviews.llvm.org/D117250#3242166>, @oontvoo wrote:

>> Specifically the proliferation of closed source libraries for analytics / fraud / payments are very common, and might have these subtle bugs that developers cannot easily fix. Really I think flipping the default would just be a benefit for folks who were onboarding.
>
> Can you elaborate what kind of bugs  *not* deduping literals by default  could lead to?

I mean I guess literally anything right? The case I found for us was luckily a crasher (repro here https://github.com/llvm/llvm-project/issues/51822) but given some logic error who knows I guess?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117250/new/

https://reviews.llvm.org/D117250