[PATCH] D117250: [lld-macho] Mention string literal deduplication as a difference from ld64

Thu Jan 13 16:18:57 PST 2022

oontvoo added a comment.

> Specifically the proliferation of closed source libraries for analytics / fraud / payments are very common, and might have these subtle bugs that developers cannot easily fix. Really I think flipping the default would just be a benefit for folks who were onboarding.

Can you elaborate what kind of bugs  *not* deduping literals by default  could lead to?

I think I agree with int3 here that de-duping by default is more likely to lead to bugs. (in fact, we've already found a lot of cases in our codebase where people incorrectly depended on it; none of which would likely have been identified had we not tried switching over to lld)

In D117250#3241888 <https://reviews.llvm.org/D117250#3241888>, @int3 wrote:

> That's a fair argument. @thakis @oontvoo @MaskRay, do y'all have any thoughts on this?

I guess my vote is on the current behaviour :) 🗳

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117250/new/

https://reviews.llvm.org/D117250