[PATCH] D117111: [AArch64] Add native CPU detection for Ampere1

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls added a comment.

I'm afraid I don't know if it's possible to check anywhere in public documentation that the values 0xc0 and 0xac3 are correct.
I'm assuming you verified those are the correct.
The code looks good, apart from one place where clang-format suggests different indentation.
With that indentation adapted, this looks good to me.



================
Comment at: llvm/lib/Support/Host.cpp:298-300
+    return StringSwitch<const char *>(Part)
+      .Case("0xac3", "ampere1")
+      .Default("generic");
----------------
Please adjust the formatting to be in line with what clang-format suggests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117111/new/

https://reviews.llvm.org/D117111