[PATCH] D117145: [CMake] Option -fno-shrink-wrap is incorrectly handled

Luís Ferreira via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 12 13:32:28 PST 2022


ljmf00 created this revision.
Herald added a subscriber: mgorny.
ljmf00 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

CMake variables are case sensitive, and Uppercase_* variables doesn't exist.
This patch uses the correct variable.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117145

Files:
  llvm/cmake/modules/HandleLLVMOptions.cmake


Index: llvm/cmake/modules/HandleLLVMOptions.cmake
===================================================================
--- llvm/cmake/modules/HandleLLVMOptions.cmake
+++ llvm/cmake/modules/HandleLLVMOptions.cmake
@@ -324,7 +324,7 @@
   endif()
   # GCC for MIPS can miscompile LLVM due to PR37701.
   if(CMAKE_COMPILER_IS_GNUCXX AND LLVM_NATIVE_ARCH STREQUAL "Mips" AND
-         NOT Uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG")
+         NOT uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG")
     add_flag_or_print_warning("-fno-shrink-wrap" FNO_SHRINK_WRAP)
   endif()
   # gcc with -O3 -fPIC generates TLS sequences that violate the spec on


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117145.399431.patch
Type: text/x-patch
Size: 638 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220112/0e40a949/attachment.bin>


More information about the llvm-commits mailing list