[PATCH] D117144: [CMake][ELF] Enable -fno-semantic-interposition on release builds

Luís Ferreira via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 12 13:31:24 PST 2022


ljmf00 created this revision.
ljmf00 added a reviewer: MaskRay.
Herald added a subscriber: mgorny.
ljmf00 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

When `-fPIC` is enabled via `LLVM_ENABLE_PIC`, `-fno-semantic-interposition`
optimization flag is added on both Release and Debug builds.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117144

Files:
  llvm/cmake/modules/HandleLLVMOptions.cmake


Index: llvm/cmake/modules/HandleLLVMOptions.cmake
===================================================================
--- llvm/cmake/modules/HandleLLVMOptions.cmake
+++ llvm/cmake/modules/HandleLLVMOptions.cmake
@@ -316,9 +316,9 @@
     # Older Clang may support -fno-semantic-interposition but it used local
     # aliases to optimize global variables, which is incompatible with copy
     # relocations due to -fno-pic.
-    if ((CMAKE_COMPILER_IS_GNUCXX AND
+    if (NOT uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG" AND ((CMAKE_COMPILER_IS_GNUCXX AND
          NOT (LLVM_NATIVE_ARCH STREQUAL "SystemZ" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 10.3))
-       OR (CMAKE_CXX_COMPILER_ID MATCHES "Clang" AND CMAKE_CXX_COMPILER_VERSION GREATER_EQUAL 13))
+       OR (CMAKE_CXX_COMPILER_ID MATCHES "Clang" AND CMAKE_CXX_COMPILER_VERSION GREATER_EQUAL 13)))
       add_flag_if_supported("-fno-semantic-interposition" FNO_SEMANTIC_INTERPOSITION)
     endif()
   endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117144.399430.patch
Type: text/x-patch
Size: 967 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220112/2dfcc16e/attachment.bin>


More information about the llvm-commits mailing list