[PATCH] D116832: [UpdateLLCTestChecks] Allow replacing register names with variables

[David Greene via Phabricator via llvm-commits]

greened added a comment.

In D116832#3235656 <https://reviews.llvm.org/D116832#3235656>, @RKSimon wrote:

> Have you examples of actual test checks that you've had problems with that this is a answer to?

I do, but my previous employer has them.  As I said, this really becomes necessary when you start paring down the checks.  Code may change in other places that you don't care about and then that changes register allocation.

> TBH This looks like a lot of over complication for little reward - so often when checks getting hidden by things like this we discover later on that it was also hiding flaws that we should be dealing with.

Can you explain this a bit more?  What sorts of issues are you worried about?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116832/new/

https://reviews.llvm.org/D116832