[PATCH] D116832: [UpdateLLCTestChecks] Allow replacing register names with variables

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 11 18:39:54 PST 2022


pengfei added a comment.

Agreed with Simon, this is a disaster for doing code review. I believe almost lit tests won't be affected by RA changes given they are concise. For test cases that already complicated, the regexes make the readablity even worse.
According to my experience, jumping between xmm0 and xmm1 is much more tolerable that regexes. And yes, it's easy to hide unnoticeable flaws.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116832/new/

https://reviews.llvm.org/D116832



More information about the llvm-commits mailing list