[PATCH] D117000: [LICM] Generalize unwinding check during scalar promotion

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM now if you remove the sret check (i.e invert the stack).  LGTM once the sret patch lands otherwise.



================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:1931
+  bool RequiresNoCaptureBeforeUnwind;
+  return isNotVisibleOnUnwind(Object, RequiresNoCaptureBeforeUnwind) &&
+         (!RequiresNoCaptureBeforeUnwind ||
----------------
I find compound conditions more confusing that an extra if check.  I'd turn this into a series of early return if-clauses personally.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117000/new/

https://reviews.llvm.org/D117000