[PATCH] D116581: [Aarch64] Customer lowering of COPYSIGN to SIMD should check for NEON availability

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

In D116581#3230813 <https://reviews.llvm.org/D116581#3230813>, @akshaykumars614 wrote:

> @dmgreen , I have updated the run lines.
> I am feeling difficult in finding example for adding f64/f32/f16 tests in the testcase. It will be helpful if you provide me with the example.

They should look something like this: https://godbolt.org/z/qvGs1G53M. With other half/double versions too.



================
Comment at: llvm/test/CodeGen/AArch64/fcopysign.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
-; RUN: llc -o - %s | FileCheck %s
+; RUN: llc < %s -march=aarch64 -mattr -neon | FileCheck -check-prefix=CHECK-NONEON %s
 ; Check that selection dag legalization of fcopysign works in cases with
----------------
dmgreen wrote:
> Can you make sure there is a "with neon" and a "without neon" run line. That way we test both cases.
> 
> The update script doesn't remove old CHECK lines that have been removed fro the RUN lines - those need to be removed manually (or keep the old run lines with the same check-prefix, they should then be updated).
We likely don't need the duplicate first line. I would change these run lines to:
```
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
; RUN: llc < %s -march=aarch64-none-eabi | FileCheck %s
; RUN: llc < %s -march=aarch64-none-eabi -mattr -neon | FileCheck -check-prefix=CHECK-NONEON %s
```

And remove the "target triple = .." line below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116581/new/

https://reviews.llvm.org/D116581