[PATCH] D116556: [llvm-objcopy] Implement the PE-COFF specific --subsystem option

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/COFF/pe-fields.test:5-7
+# RUN: not llvm-objcopy --subsystem windows %t.in.obj %t.out.obj 2>&1 | FileCheck %s
+
+# CHECK: '{{.*}}.in.obj': unable to set subsystem on a relocatable object file
----------------
jhenderson wrote:
> This is how we usually check the file names in error messages.
Ok, I'll try that. (I was afraid of the risk of extra fragility with potential backslashes as path separators, which can be tricky/require strict correct quoting throughout the tools. But I'll push it through the premerge testing to see that it's ok before landing.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116556/new/

https://reviews.llvm.org/D116556